The first element of prayer should be adoration, or praise. The Psalms, which are inspired samples of godly prayer, are heavily weighted on the side of adoration. I've noticed over many years that as we grow in the discipline and in the delight of prayer, it seems that we naturally spend more and more of our time on this first element. Second, prayer should include confession of our sin; as we remember who we are when we come into God's presence, we see that we have come short of His holiness and have need of His forgiveness. Third, when we pray, we should always give thanks, remembering the grace and mercy God has shown toward us. Fourth, prayer rightly includes supplication or petition, bringing our requests for the needs of others and ourselves to God.